Conversation
opficdev
commented
Mar 16, 2026
opficdev
commented
- closed HomeView의 액션을 정리한다 #277
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 풀 리퀘스트는 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| case .addTodo(let todo): | ||
| Task { | ||
| do { | ||
| send(.setAppending(true)) | ||
| defer { send(.setLoading(.overlay, false)) } | ||
| send(.setLoading(.overlay, true)) | ||
| try await upsertTodoUseCase.execute(todo) | ||
| let page = try await fetchRecentTodos() | ||
| let items = page.items | ||
| .filter { $0.createdAt != $0.updatedAt } | ||
| .prefix(5) | ||
| .map { RecentTodoItem(from: $0) } | ||
| send(.fetchRecentTodos(items)) | ||
| send(.updateRecentTodos(items)) | ||
| } catch { | ||
| send(.setAlert(isPresented: true, type: .error)) | ||
| } | ||
| } | ||
| case .fetchRecentTodos: | ||
| Task { | ||
| do { | ||
| defer { send(.setRecentTodosLoading(false)) } | ||
| send(.setRecentTodosLoading(true)) | ||
| defer { send(.setLoading(.recentTodos, false)) } | ||
| send(.setLoading(.recentTodos, true)) | ||
| let page = try await fetchRecentTodos() | ||
| let items = page.items | ||
| .filter { $0.createdAt != $0.updatedAt } | ||
| .prefix(5) | ||
| .map { RecentTodoItem(from: $0) } | ||
| send(.fetchRecentTodos(items)) | ||
| send(.updateRecentTodos(items)) | ||
| } catch { | ||
| send(.setAlert(isPresented: true, type: .error)) | ||
| } | ||
| } |
There was a problem hiding this comment.
.addTodo와 .fetchRecentTodos 사이드 이펙트 처리 로직에 중복 코드가 있습니다. 최근 Todo 목록을 가져와서 상태를 업데이트하는 로직을 별도의 private 메서드로 추출하여 중복을 제거하고 코드 유지보수성을 높이는 것을 제안합니다.
예를 들어, 다음과 같은 private helper 메서드를 추가할 수 있습니다.
private func refreshRecentTodos() async throws {
let page = try await fetchRecentTodos()
let items = page.items
.filter { $0.createdAt != $0.updatedAt }
.prefix(5)
.map { RecentTodoItem(from: $0) }
send(.updateRecentTodos(items))
}그리고 이 메서드를 사용하여 .addTodo와 .fetchRecentTodos 케이스를 리팩토링할 수 있습니다.
case .addTodo(let todo):
Task {
do {
defer { send(.setLoading(.overlay, false)) }
send(.setLoading(.overlay, true))
try await upsertTodoUseCase.execute(todo)
try await refreshRecentTodos()
} catch {
send(.setAlert(isPresented: true, type: .error))
}
}
case .fetchRecentTodos:
Task {
do {
defer { send(.setLoading(.recentTodos, false)) }
send(.setLoading(.recentTodos, true))
try await refreshRecentTodos()
} catch {
send(.setAlert(isPresented: true, type: .error))
}
}1 participant
